TennyZhuang commented on code in PR #254: URL: https://github.com/apache/iceberg-rust/pull/254#discussion_r1521025132
########## crates/catalog/rest/src/catalog.rs: ########## @@ -113,6 +117,19 @@ impl RestCatalogConfig { ), ]); + if let Some(token) = self.props.get("token") { Review Comment: I just follow the previous style. If we should extract a constant, we should do it in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org