rdblue commented on code in PR #8252:
URL: https://github.com/apache/iceberg/pull/8252#discussion_r1520294375
##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -289,8 +294,11 @@ protected ManifestContent content() {
static class V1Writer extends ManifestWriter<DataFile> {
private final V1Metadata.IndexedManifestEntry entryWrapper;
- V1Writer(PartitionSpec spec, OutputFile file, Long snapshotId) {
+ V1Writer(PartitionSpec spec, EncryptedOutputFile file, Long snapshotId) {
super(spec, file, snapshotId);
+ Preconditions.checkState(
+ file.keyMetadata() == null || file.keyMetadata() ==
EncryptionKeyMetadata.EMPTY,
+ "V1 tables don't support encryption");
Review Comment:
Why don't v1 tables support encryption? I don't see why v2 could support
encryption but v1 cannot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
