rdblue commented on code in PR #8252:
URL: https://github.com/apache/iceberg/pull/8252#discussion_r1520288711
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -151,22 +153,31 @@ public static ManifestWriter<DataFile>
write(PartitionSpec spec, OutputFile outp
*
* @param formatVersion a target format version
* @param spec a {@link PartitionSpec}
- * @param outputFile an {@link OutputFile} where the manifest will be written
+ * @param encryptedOutputFile an {@link EncryptedOutputFile} where the
manifest will be written
* @param snapshotId a snapshot ID for the manifest entries, or null for an
inherited ID
* @return a manifest writer
*/
public static ManifestWriter<DataFile> write(
- int formatVersion, PartitionSpec spec, OutputFile outputFile, Long
snapshotId) {
+ int formatVersion,
+ PartitionSpec spec,
+ EncryptedOutputFile encryptedOutputFile,
+ Long snapshotId) {
switch (formatVersion) {
case 1:
- return new ManifestWriter.V1Writer(spec, outputFile, snapshotId);
+ return new ManifestWriter.V1Writer(spec, encryptedOutputFile,
snapshotId);
case 2:
- return new ManifestWriter.V2Writer(spec, outputFile, snapshotId);
+ return new ManifestWriter.V2Writer(spec, encryptedOutputFile,
snapshotId);
}
throw new UnsupportedOperationException(
"Cannot write manifest for table version: " + formatVersion);
}
+ public static ManifestWriter<DataFile> write(
Review Comment:
Need Javadoc here.
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -208,6 +219,12 @@ public static ManifestWriter<DeleteFile>
writeDeleteManifest(
"Cannot write manifest for table version: " + formatVersion);
}
+ public static ManifestWriter<DeleteFile> writeDeleteManifest(
Review Comment:
Javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
