rdblue commented on code in PR #8252:
URL: https://github.com/apache/iceberg/pull/8252#discussion_r1520289913
##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -52,13 +56,14 @@ public abstract class ManifestWriter<F extends
ContentFile<F>> implements FileAp
private long deletedRows = 0L;
private Long minDataSequenceNumber = null;
- private ManifestWriter(PartitionSpec spec, OutputFile file, Long snapshotId)
{
- this.file = file;
+ private ManifestWriter(PartitionSpec spec, EncryptedOutputFile file, Long
snapshotId) {
+ this.file = file.encryptingOutputFile();
this.specId = spec.specId();
- this.writer = newAppender(spec, file);
+ this.writer = newAppender(spec, file.encryptingOutputFile());
Review Comment:
Shouldn't this pass `this.file`?
##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -52,13 +56,14 @@ public abstract class ManifestWriter<F extends
ContentFile<F>> implements FileAp
private long deletedRows = 0L;
private Long minDataSequenceNumber = null;
- private ManifestWriter(PartitionSpec spec, OutputFile file, Long snapshotId)
{
- this.file = file;
+ private ManifestWriter(PartitionSpec spec, EncryptedOutputFile file, Long
snapshotId) {
+ this.file = file.encryptingOutputFile();
this.specId = spec.specId();
- this.writer = newAppender(spec, file);
+ this.writer = newAppender(spec, file.encryptingOutputFile());
Review Comment:
Shouldn't this pass `this.file`? I don't think you want to call
`encryptingOutputFile` twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
