marvinlanhenke commented on code in PR #237:
URL: https://github.com/apache/iceberg-rust/pull/237#discussion_r1518565281
##########
crates/catalog/hms/src/catalog.rs:
##########
@@ -95,9 +106,156 @@ impl HmsCatalog {
client: HmsClient(client),
})
}
+
+ /// Create and extract properties from `hive_metastore::hms::Database`.
+ pub fn properties_from_database(database: &Database) -> HashMap<String,
String> {
Review Comment:
I had them in utils before - and was not sure if they should stay there. I
moved them back to utils - however I think the conversion `from_namespace` and
`to_namespace` need an extra type like @liurenjie1024 suggested. This would
clean up both the catalog and utils, i think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
