Xuanwo commented on code in PR #237:
URL: https://github.com/apache/iceberg-rust/pull/237#discussion_r1518480899
##########
crates/catalog/hms/Cargo.toml:
##########
@@ -33,5 +33,12 @@ anyhow = { workspace = true }
async-trait = { workspace = true }
hive_metastore = { workspace = true }
iceberg = { workspace = true }
+log = "0.4.20"
Review Comment:
It's better to add in workspace instead.
##########
crates/catalog/hms/src/catalog.rs:
##########
@@ -95,9 +106,156 @@ impl HmsCatalog {
client: HmsClient(client),
})
}
+
+ /// Create and extract properties from `hive_metastore::hms::Database`.
+ pub fn properties_from_database(database: &Database) -> HashMap<String,
String> {
Review Comment:
nit: Maybe we can extract those helper utils in another file to make
`catalog.rs` clean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
