ajantha-bhat commented on code in PR #9884:
URL: https://github.com/apache/iceberg/pull/9884#discussion_r1514921889
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -122,11 +124,20 @@ public void initialize(Map<String, String> newProperties)
{
close(); // close and discard any existing FileIO instances
this.properties = SerializableMap.copyOf(newProperties);
isClosed.set(false);
+ // load custom IO scheme handlers (starting with resolving-io.schemes.
prefix)
+ for (String key : this.properties.keySet()) {
+ if (key.startsWith(SCHEME_PROPERTY_PREFIX)) {
+ this.schemeToFileIo.put(
+ key.substring(SCHEME_PROPERTY_PREFIX.length()),
this.properties.get(key));
+ }
+ }
}
@Override
public void close() {
if (isClosed.compareAndSet(false, true)) {
+ schemeToFileIo.clear();
Review Comment:
we should initlaize to DEFAULT_SCHEME_TO_FILE_IO here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
