ajantha-bhat commented on code in PR #9884:
URL: https://github.com/apache/iceberg/pull/9884#discussion_r1514759756


##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -122,6 +124,15 @@ public void initialize(Map<String, String> newProperties) {
     close(); // close and discard any existing FileIO instances
     this.properties = SerializableMap.copyOf(newProperties);
     isClosed.set(false);
+    // populate default IO schema handler

Review Comment:
   ```suggestion
       // populate default IO scheme handler
   ```



##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -122,6 +124,15 @@ public void initialize(Map<String, String> newProperties) {
     close(); // close and discard any existing FileIO instances
     this.properties = SerializableMap.copyOf(newProperties);
     isClosed.set(false);
+    // populate default IO schema handler
+    this.schemeToFileIo.putAll(DEFAULT_SCHEME_TO_FILE_IO);
+    // load custom IO schema handlers (starting with resolving-io.schemes. 
prefix)

Review Comment:
   ```suggestion
       // load custom IO scheme handlers (starting with `resolving-io.schemes.` 
prefix)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to