ajantha-bhat commented on code in PR #9884: URL: https://github.com/apache/iceberg/pull/9884#discussion_r1514874407
########## core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java: ########## @@ -219,7 +230,7 @@ DelegateFileIO io(String location) { @VisibleForTesting String implFromLocation(String location) { - return SCHEME_TO_FILE_IO.getOrDefault(scheme(location), FALLBACK_IMPL); + return schemeToFileIo.getOrDefault(scheme(location), FALLBACK_IMPL); Review Comment: `schemeToFileIo.clear()` part was ok. I think this should use `DEFAULT_SCHEME_TO_FILE_IO`, if `schemeToFileIo` is empty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org