rdblue commented on code in PR #8252:
URL: https://github.com/apache/iceberg/pull/8252#discussion_r1506324791
##########
.palantir/revapi.yml:
##########
@@ -1018,6 +1018,30 @@ acceptedBreaks:
old: "method void
org.apache.iceberg.PositionDeletesTable.PositionDeletesBatchScan::<init>(org.apache.iceberg.Table,\
\ org.apache.iceberg.Schema, org.apache.iceberg.TableScanContext)"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeChanged"
+ old: "method org.apache.iceberg.io.OutputFile
org.apache.iceberg.SnapshotProducer<ThisT>::newManifestOutput()\
+ \ @ org.apache.iceberg.BaseOverwriteFiles"
+ new: "method org.apache.iceberg.encryption.EncryptedOutputFile
org.apache.iceberg.SnapshotProducer<ThisT>::newManifestOutput()\
+ \ @ org.apache.iceberg.BaseOverwriteFiles"
+ justification: "{encrypted manifest}"
+ - code: "java.method.returnTypeChanged"
+ old: "method org.apache.iceberg.io.OutputFile
org.apache.iceberg.SnapshotProducer<ThisT>::newManifestOutput()\
+ \ @ org.apache.iceberg.BaseReplacePartitions"
+ new: "method org.apache.iceberg.encryption.EncryptedOutputFile
org.apache.iceberg.SnapshotProducer<ThisT>::newManifestOutput()\
+ \ @ org.apache.iceberg.BaseReplacePartitions"
+ justification: "{encrypted manifest}"
+ - code: "java.method.returnTypeChanged"
+ old: "method org.apache.iceberg.io.OutputFile
org.apache.iceberg.SnapshotProducer<ThisT>::newManifestOutput()\
+ \ @ org.apache.iceberg.BaseRewriteManifests"
+ new: "method org.apache.iceberg.encryption.EncryptedOutputFile
org.apache.iceberg.SnapshotProducer<ThisT>::newManifestOutput()\
+ \ @ org.apache.iceberg.BaseRewriteManifests"
+ justification: "{encrypted manifest}"
+ - code: "java.method.returnTypeChanged"
+ old: "method org.apache.iceberg.io.OutputFile
org.apache.iceberg.SnapshotProducer<ThisT>::newManifestOutput()\
+ \ @ org.apache.iceberg.StreamingDelete"
+ new: "method org.apache.iceberg.encryption.EncryptedOutputFile
org.apache.iceberg.SnapshotProducer<ThisT>::newManifestOutput()\
+ \ @ org.apache.iceberg.StreamingDelete"
+ justification: "{encrypted manifest}"
Review Comment:
We cannot break the core API like this. These methods need to be supported
and deprecated for at least a minor release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
