ggershinsky commented on code in PR #8252:
URL: https://github.com/apache/iceberg/pull/8252#discussion_r1506213324
##########
core/src/main/java/org/apache/iceberg/encryption/AesGcmOutputStream.java:
##########
@@ -158,4 +163,17 @@ private void encryptAndWriteBlock() throws IOException {
positionInPlainBlock = 0;
currentBlockIndex++;
}
+
+ public static long gcmEncryptionLength(long plainLength) {
Review Comment:
> Can't we just check the bytes written?
Yes we can! Excellent idea! For me, it was "straightforward" to re-use this
util function I had from before; but replacing it with a direct call to the
target stream length is WAY simpler and more intuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
