ggershinsky commented on code in PR #8252: URL: https://github.com/apache/iceberg/pull/8252#discussion_r1505931284
########## core/src/main/java/org/apache/iceberg/ManifestWriter.java: ########## @@ -290,7 +295,7 @@ static class V1Writer extends ManifestWriter<DataFile> { private final V1Metadata.IndexedManifestEntry entryWrapper; V1Writer(PartitionSpec spec, OutputFile file, Long snapshotId) { - super(spec, file, snapshotId); + super(spec, EncryptedFiles.plainAsEncryptedOutput(file), snapshotId); Review Comment: todo: accept EncryptedOutputFile, and throw exception if key metadata is not null / empty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org