pvary commented on code in PR #9606:
URL: https://github.com/apache/iceberg/pull/9606#discussion_r1505428596
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##########
@@ -68,6 +75,42 @@ public static Schema convert(TableSchema schema) {
return freshIdentifierFieldIds(iSchema, schema);
}
+ /** Convert the flink table schema to apache iceberg schema with column
comment. */
+ public static Schema convert(ResolvedCatalogTable catalogTable) {
+ List<Column> tableColumns = catalogTable.getResolvedSchema().getColumns();
+ // copy from org.apache.flink.table.api.Schema#toRowDataType
+ DataTypes.Field[] fields =
+ tableColumns.stream()
+ .map(
+ column -> {
+ if (column.getComment().isPresent()) {
+ return DataTypes.FIELD(
+ column.getName(), column.getDataType(),
column.getComment().get());
+ } else {
+ return DataTypes.FIELD(column.getName(),
column.getDataType());
+ }
+ })
+ .toArray(DataTypes.Field[]::new);
+
+ LogicalType schemaType = DataTypes.ROW(fields).notNull().getLogicalType();
+ Preconditions.checkArgument(
+ schemaType instanceof RowType, "Schema logical type should be
RowType.");
+
+ RowType root = (RowType) schemaType;
+ Type converted = root.accept(new FlinkTypeToType(root));
+ Schema iSchema = new Schema(converted.asStructType().fields());
+ return freshIdentifierFieldIds(iSchema, catalogTable.getSchema());
+ }
+
+ public static Map<String, String> getColumnComments(CatalogTable
catalogTable) {
Review Comment:
Do we need this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
