Re: [PR] Flink: Supports specifying comment for iceberg fields in create table and addcolumn syntax using flinksql [iceberg]

[via GitHub]

stevenzwu commented on code in PR #9606:
URL: https://github.com/apache/iceberg/pull/9606#discussion_r1498341486


##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java:
##########
@@ -307,13 +320,13 @@ public void testAlterTableAddColumn() {
     assertThat(schemaBefore.asStruct())
         .isEqualTo(
             new Schema(Types.NestedField.optional(1, "id", 
Types.LongType.get())).asStruct());
-    sql("ALTER TABLE tl ADD (dt STRING)");
+    sql("ALTER TABLE tl ADD (dt STRING COMMENT 'comment for dt')");
     Schema schemaAfter1 = table("tl").schema();
     assertThat(schemaAfter1.asStruct())
         .isEqualTo(
             new Schema(
                     Types.NestedField.optional(1, "id", Types.LongType.get()),
-                    Types.NestedField.optional(2, "dt", 
Types.StringType.get()))
+                    Types.NestedField.optional(2, "dt", 
Types.StringType.get(), "comment for dt"))
                 .asStruct());
     // Add multiple columns
     sql("ALTER TABLE tl ADD (col1 STRING, col2 BIGINT)");

Review Comment:
   I would just change of the column here with comment and leave the line 
310/323 not changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org