pvary commented on code in PR #9606:
URL: https://github.com/apache/iceberg/pull/9606#discussion_r1505427401
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkDynamicTableFactory.java:
##########
@@ -187,7 +188,7 @@ private static TableLoader createTableLoader(
// Create table if not exists in the external catalog.
if (!flinkCatalog.tableExists(objectPath)) {
try {
- flinkCatalog.createIcebergTable(objectPath, catalogBaseTable, true);
+ flinkCatalog.createIcebergTable(objectPath, (ResolvedCatalogTable)
catalogBaseTable, true);
Review Comment:
I'm a bit uncomfortable with this cast. I don't have time ATM, but how
complicated would be to change the method parameter type to
`ResolvedCatalogTable`?
If it is complicated, or the resulting change is too big, then minimally an
`instanceof` precondition check would be nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
