jackye1995 commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1499968208
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -1045,6 +1094,27 @@ public void commitTransaction(SessionContext context,
List<TableCommit> commits)
public List<TableIdentifier> listViews(SessionContext context, Namespace
namespace) {
checkNamespaceIsValid(namespace);
+ Map<String, String> queryParams = Maps.newHashMap();
+ if (restPaginationEnabled) {
+ List<TableIdentifier> identifiers = Lists.newArrayList();
+ String pageToken = "";
+ queryParams.put("pageSize", restPageSize);
+
+ while (pageToken != null) {
Review Comment:
I think we should not run the full execution in a loop directly. We should
lazily load the list, something like
https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/dynamodbv2/datamodeling/PaginatedList.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
