geruh commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1499864124
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -490,12 +522,29 @@ public void createNamespace(
@Override
public List<Namespace> listNamespaces(SessionContext context, Namespace
namespace) {
- Map<String, String> queryParams;
- if (namespace.isEmpty()) {
- queryParams = ImmutableMap.of();
- } else {
- // query params should be unescaped
- queryParams = ImmutableMap.of("parent",
RESTUtil.NAMESPACE_JOINER.join(namespace.levels()));
+ Map<String, String> queryParams = Maps.newHashMap();
+ if (!namespace.isEmpty()) {
+ queryParams.put("parent",
RESTUtil.NAMESPACE_JOINER.join(namespace.levels()));
+ }
+ if (restPaginationEnabled) {
+ List<Namespace> namespaces = Lists.newArrayList();
+ String pageToken = "";
+ queryParams.put("pageSize", restPageSize);
+
+ while (pageToken != null) {
+ queryParams.put("pageToken", pageToken);
+ LOG.error("Sending list namespaces request");
Review Comment:
Did you mean to put this here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
