geruh commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1499953848
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -224,6 +229,12 @@ public void initialize(String name, Map<String, String>
unresolved) {
client, tokenRefreshExecutor(), token,
expiresAtMillis(mergedProps), catalogAuth);
}
+ String restPaginationEnabledValue =
mergedProps.get(REST_PAGINATION_ENABLED);
Review Comment:
Do we need the feature flag? We designed these changes in a way that makes
the pagination backwards compatible. Therefore, if the service response
includes more results than the page size it should still work. Then we can
simplify the logic in the listing methods to handle pagination but still
accommodate for services sending all results in single response.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
