nastra commented on code in PR #9760:
URL: https://github.com/apache/iceberg/pull/9760#discussion_r1497784895
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSnapshotTableProcedure.java:
##########
@@ -103,13 +102,13 @@ public void testSnapshotWithProperties() throws
IOException {
sql("SELECT * FROM %s ORDER BY id", tableName));
}
- @Test
+ @TestTemplate
public void testSnapshotWithAlternateLocation() throws IOException {
- Assume.assumeTrue(
- "No Snapshoting with Alternate locations with Hadoop Catalogs",
- !catalogName.contains("hadoop"));
- String location = temp.newFolder().toString();
- String snapshotLocation = temp.newFolder().toString();
+ assumeThat(catalogName)
+ .as("No Snapshoting with Alternate locations with Hadoop Catalogs")
+ .doesNotContain("hadoop");
+ String location = temp.toFile().toString();
+ String snapshotLocation = temp.toFile().toString();
Review Comment:
both now point to the same location, whereas in the previous version of the
code they were pointing to different folders, so I think we should fix that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
