nastra commented on code in PR #9760:
URL: https://github.com/apache/iceberg/pull/9760#discussion_r1497772374
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRemoveOrphanFilesProcedure.java:
##########
@@ -505,10 +496,10 @@ public void testRemoveOrphanFilesWithStatisticFiles()
throws Exception {
+ "table => '%s',"
+ "older_than => TIMESTAMP '%s')",
catalogName, tableIdent, currentTimestamp);
- Assertions.assertThat(output).as("Should be no orphan files").isEmpty();
+ assertThat(output).as("Should be no orphan files").isEmpty();
- Assertions.assertThat(statsLocation.exists()).as("stats file should
exist").isTrue();
- Assertions.assertThat(statsLocation.length())
+ assertThat(statsLocation.exists()).as("stats file should exist").isTrue();
+ assertThat(statsLocation.length())
Review Comment:
```suggestion
assertThat(statsLocation).hasSize(statisticsFile.fileSizeInBytes())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
