nastra commented on code in PR #9760:
URL: https://github.com/apache/iceberg/pull/9760#discussion_r1497781508
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFilesProcedure.java:
##########
@@ -184,26 +182,27 @@ public void testExpireDeleteFilesFilter() throws
Exception {
Long.valueOf(snapshotSummary.get(ADDED_FILE_SIZE_PROP)))),
output);
- Assert.assertEquals(4, TestHelpers.deleteFiles(table).size());
+ assertThat(TestHelpers.deleteFiles(table)).hasSize(4);
}
- @Test
+ @TestTemplate
public void testInvalidOption() throws Exception {
createTable();
- Assert.assertThrows(
- "Cannot use options [foo], they are not supported by the action or the
rewriter BIN-PACK",
- IllegalArgumentException.class,
- () ->
- sql(
- "CALL %s.system.rewrite_position_delete_files("
- + "table => '%s',"
- + "options => map("
- + "'foo', 'bar'))",
- catalogName, tableIdent));
+ Assertions.assertThatThrownBy(
Review Comment:
```suggestion
assertThatThrownBy(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
