jackye1995 commented on code in PR #9717:
URL: https://github.com/apache/iceberg/pull/9717#discussion_r1495074341


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3324,6 +3348,184 @@ components:
           type: integer
           format: int64
 
+    BooleanTypeValue:
+      type: boolean
+
+    IntegerTypeValue:
+      type: integer
+
+    LongTypeValue:
+      type: integer
+      format: int64
+
+    FloatTypeValue:

Review Comment:
   Oh I think I get it now. The situation of `{ 1: 0.1 }` does not really exist.
   
   because 0.1 has binary representation of 0.00011001100110011... (repeated 
0011)
   
   The serialized value will be `0 * 2^-1 + 0 * 2^-2 + ... + 0 * 2^-28 + 0 * 
2^-29 + 1 * 2^-30 + 1 * 2^-31` which will be some exact decimal number. And the 
other side will receive this number and be able to recover the exact float 
number.
   
   Let me know if this is what you mean. If so, the examples here should be 
updated to reflect it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to