jackye1995 commented on code in PR #9717:
URL: https://github.com/apache/iceberg/pull/9717#discussion_r1495066733


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3324,6 +3348,184 @@ components:
           type: integer
           format: int64
 
+    BooleanTypeValue:
+      type: boolean
+
+    IntegerTypeValue:
+      type: integer
+
+    LongTypeValue:
+      type: integer
+      format: int64
+
+    FloatTypeValue:

Review Comment:
   My understanding is that we need to consider both directions, because this 
is a wire protocol and you expect the other side to deserialize to exactly the 
same value.
   
   Suppose A sends B a JSON value of the upper bound `{ 1: 0.1 }`, where column 
1 is of float type, the other side cannot really reconstruct the original float 
binary.
   
   Maybe I am misunderstanding what you mean by "each binary representation can 
be expressed as a decimal number", could you help walk through that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to