jackye1995 commented on code in PR #9717: URL: https://github.com/apache/iceberg/pull/9717#discussion_r1495090469
########## open-api/rest-catalog-open-api.yaml: ########## @@ -3324,6 +3348,184 @@ components: type: integer format: int64 + BooleanTypeValue: + type: boolean + + IntegerTypeValue: + type: integer + + LongTypeValue: + type: integer + format: int64 + + FloatTypeValue: Review Comment: I think there is a potential issue of this in the current implementation. We directly use Jackson's writeNumber(float), which has some default rounding behavior if I remember correctly. Let me double check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org