zachdisc commented on code in PR #9731: URL: https://github.com/apache/iceberg/pull/9731#discussion_r1494866526
########## api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java: ########## @@ -44,6 +45,16 @@ public interface RewriteManifests */ RewriteManifests rewriteIf(Predicate<ManifestFile> predicate); + /** + * Rewrite manifests in a given order, based on partition columns + * + * <p>If not set, manifests will be rewritten in the order of the table's spec. + * + * @param partitionSortOrder a list of partition field names Review Comment: Ack - didn't know about multi-arg transforms! I originally had at as expecting the transform name (`sometime_day` transformed name instead of the underlying `sometime` value). Makes the implementation easier but makes the user have to know what the internally transformed names are referred to as. With multi-arg I think this no longer viable for sure. Could always accept both and check against either the value or transform name. Think that is just too convoluted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org