RussellSpitzer commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1494784489
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -208,7 +243,15 @@ private RewriteManifests.Result
rewriteManifests(ManifestContent content) {
if (spec.isUnpartitioned()) {
newManifests = writeUnpartitionedManifests(content, manifestEntryDF,
targetNumManifests);
} else {
- newManifests = writePartitionedManifests(content, manifestEntryDF,
targetNumManifests);
+ if (partitionSortColumns != null) {
Review Comment:
Should both of these branches be the same? Just one uses the default
ordering and one doesn't? That is what we declared in the api above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
