RussellSpitzer commented on code in PR #9731: URL: https://github.com/apache/iceberg/pull/9731#discussion_r1494774386
########## api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java: ########## @@ -44,6 +45,16 @@ public interface RewriteManifests */ RewriteManifests rewriteIf(Predicate<ManifestFile> predicate); + /** + * Rewrite manifests in a given order, based on partition columns + * + * <p>If not set, manifests will be rewritten in the order of the table's spec. + * + * @param partitionSortOrder a list of partition field names Review Comment: Should this be partition transform names? Considering we will also have multi-arg transforms coming up I think that is probably more accurate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org