amogh-jahagirdar commented on code in PR #9717:
URL: https://github.com/apache/iceberg/pull/9717#discussion_r1490110431


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3324,6 +3348,97 @@ components:
           type: integer
           format: int64
 
+    TypeValue:
+      oneOf:
+        - $ref: '#/components/schemas/PrimitiveTypeValue'

Review Comment:
   Ah my bad I only saw ContentFile, for the actual update we need 
schema/partition-spec so yes these data types do need to be spec'd out in rest.
   
   Option 1 seems better to me; it does not have as much indirection as option 
2 has and the types are just explicitly laid out. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to