amogh-jahagirdar commented on code in PR #9717:
URL: https://github.com/apache/iceberg/pull/9717#discussion_r1488618480
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3324,6 +3348,97 @@ components:
type: integer
format: int64
+ TypeValue:
+ oneOf:
+ - $ref: '#/components/schemas/PrimitiveTypeValue'
Review Comment:
I think documenting how the different types are serialized is important but
just to make sure for `DecimalTypeValue` and `TimestampTypeValue` those are
just examples right? We don't need those data types spec'd out for what we're
trying to do here right?
##########
open-api/rest-catalog-open-api.py:
##########
@@ -801,6 +801,17 @@ class AddSchemaUpdate(BaseUpdate):
)
+class AppendDataFileUpdate(BaseUpdate):
+ action: Literal['append-data-files']
+ added_data_files: List[ContentFile] = Field(
+ ...,
+ alias='added-data-files',
+ description='List of datafiles to be appended to a table',
Review Comment:
Nit: 'List of data files' instead of `datafiles`
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2494,6 +2495,28 @@ components:
type: integer
format: int64
+ AppendDataFileUpdate:
+ allOf:
+ - $ref: '#/components/schemas/BaseUpdate'
+ required:
+ - action
+ - added-data-files
+ - schema
+ - spec
+ properties:
+ action:
+ type: string
+ enum: [ "append-data-files" ]
+ added-data-files:
Review Comment:
I'd +1 just `data-files`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
