jackye1995 commented on code in PR #9717:
URL: https://github.com/apache/iceberg/pull/9717#discussion_r1489878930
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3324,6 +3348,97 @@ components:
type: integer
format: int64
+ TypeValue:
+ oneOf:
+ - $ref: '#/components/schemas/PrimitiveTypeValue'
Review Comment:
So to summarize the 2 options we are discussing so far:
Option 1: different schema
```
TypeValue:
oneOf:
- $ref: '#/components/schemas/DecimalTypeValue'
- $ref: '#/components/schemas/TimestampTypeValue'
- ...
DecimalTypeValue:
type: string
description: // describe serialization for decimal
...
TimestampTypeValue:
type: string
description: // describe serialization for timestamp
...
```
Option 2: same schema, just document different serializations
```
TypeValue:
oneOf:
- $ref: '#/components/schemas/PrimitiveTypeValue'
- ...
PrimitiveTypeValue:
description: // describe serialization for all primitive types
oneOf:
- string
- ...
```
@rdblue @danielcweeks @amogh-jahagirdar @rahil-c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
