nastra commented on code in PR #9711:
URL: https://github.com/apache/iceberg/pull/9711#discussion_r1485812902
##########
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerLocalScan.java:
##########
@@ -135,13 +135,13 @@ public void testScanTable() throws IOException {
// Single fetch task: no MR job.
List<Object[]> rows = shell.executeStatement("SELECT * FROM
default.customers");
- Assert.assertEquals(3, rows.size());
- Assert.assertArrayEquals(new Object[] {0L, "Alice", "Brown"}, rows.get(0));
- Assert.assertArrayEquals(new Object[] {1L, "Bob", "Green"}, rows.get(1));
- Assert.assertArrayEquals(new Object[] {2L, "Trudy", "Pink"}, rows.get(2));
+ assertThat(rows).hasSize(3);
+ assertThat(rows.get(0)).isEqualTo(new Object[] {0L, "Alice", "Brown"});
Review Comment:
nit: this could also be written in a single stmt:
`assertThat(rows).containsExactly(first, second, third)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
