nastra commented on code in PR #9711:
URL: https://github.com/apache/iceberg/pull/9711#discussion_r1485811808
##########
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithMultipleCatalogs.java:
##########
@@ -18,60 +18,63 @@
*/
package org.apache.iceberg.mr.hive;
+import static org.assertj.core.api.Assertions.assertThat;
+
import java.io.IOException;
+import java.nio.file.Path;
import java.util.Collection;
import java.util.List;
import org.apache.iceberg.FileFormat;
+import org.apache.iceberg.Parameter;
+import org.apache.iceberg.ParameterizedTestExtension;
+import org.apache.iceberg.Parameters;
import org.apache.iceberg.Table;
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.data.Record;
import org.apache.iceberg.mr.InputFormatConfig;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
-import org.junit.After;
-import org.junit.AfterClass;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.BeforeClass;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
-
-@RunWith(Parameterized.class)
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.TempDir;
+
+@ExtendWith(ParameterizedTestExtension.class)
public class TestHiveIcebergStorageHandlerWithMultipleCatalogs {
private static final String[] EXECUTION_ENGINES = new String[] {"tez", "mr"};
private static final String HIVECATALOGNAME = "table1_catalog";
private static final String OTHERCATALOGNAME = "table2_catalog";
private static TestHiveShell shell;
- @Parameterized.Parameter(0)
+ @Parameter(index = 0)
public FileFormat fileFormat1;
- @Parameterized.Parameter(1)
+ @Parameter(index = 1)
public FileFormat fileFormat2;
Review Comment:
these should all be private instead of public. Could you please adjust all
of this parameters to be private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
