Re: [PR] fix #9269 Switch class level parameterized for mr [iceberg]

[via GitHub]

nastra commented on code in PR #9711:
URL: https://github.com/apache/iceberg/pull/9711#discussion_r1485808992


##########
mr/src/test/java/org/apache/iceberg/mr/TestIcebergInputFormats.java:
##########
@@ -336,26 +336,26 @@ public void testSnapshotReads() throws Exception {
     testInputFormat.create(builder.conf()).validate(expectedRecords);
   }
 
-  @Test
+  @TestTemplate
   public void testLocality() throws Exception {
     helper.createUnpartitionedTable();
     List<Record> expectedRecords = helper.generateRandomRecords(1, 0L);
     helper.appendToTable(null, expectedRecords);
 
     for (InputSplit split : 
testInputFormat.create(builder.conf()).getSplits()) {
-      Assert.assertArrayEquals(new String[] {"*"}, split.getLocations());
+      assertThat(split.getLocations()).containsExactly("*");
     }
 
     builder.preferLocality();
 
     for (InputSplit split : 
testInputFormat.create(builder.conf()).getSplits()) {
-      Assert.assertArrayEquals(new String[] {"localhost"}, 
split.getLocations());
+      assertThat(split.getLocations()).containsExactly("localhost");
     }
   }
 
-  @Test
+  @TestTemplate
   public void testCustomCatalog() throws IOException {
-    String warehouseLocation = 
temp.newFolder("hadoop_catalog").getAbsolutePath();
+    String warehouseLocation = 
temp.resolve("hadoop_catalog").toAbsolutePath().toString();

Review Comment:
   this is correct



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org