HonahX commented on code in PR #411:
URL: https://github.com/apache/iceberg-python/pull/411#discussion_r1485730495
##########
pyiceberg/table/metadata.py:
##########
@@ -404,13 +406,34 @@ def new_table_metadata(
properties: Properties = EMPTY_DICT,
table_uuid: Optional[uuid.UUID] = None,
) -> TableMetadata:
+ from pyiceberg.table import TableProperties
+
fresh_schema = assign_fresh_schema_ids(schema)
fresh_partition_spec = assign_fresh_partition_spec_ids(partition_spec,
schema, fresh_schema)
fresh_sort_order = assign_fresh_sort_order_ids(sort_order, schema,
fresh_schema)
if table_uuid is None:
table_uuid = uuid.uuid4()
+ # Remove format-version so it does not get persisted
+ format_version = int(properties.pop(TableProperties.FORMAT_VERSION,
TableProperties.DEFAULT_FORMAT_VERSION))
+ if format_version == 1:
+ return TableMetadataV1(
+ location=location,
+ schema_=fresh_schema,
Review Comment:
Is this needed? We set `schema=fresh_schema` below. It seems the resulting
metadata is still correct without this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
