amogh-jahagirdar commented on PR #411: URL: https://github.com/apache/iceberg-python/pull/411#issuecomment-1938053112
>Thanks for taking this! @amogh-jahagirdar It's great that we no longer require extra before validator for supporting the v1 metadata. Setting the relevant fields explicitly is a smart approach Thanks but I don't know about that tbh. I think it's a pretty bad API that we are somewhat forced to specify all fields even though it's redundant for V1 metadata (because it's deprecated so we want to specify the new fields, but partition-spec is still required). We should revisit that imo, but I think that can be done in a follow on PR since the goal here is to solve the original problem of not being able to create V1 tables in non-rest catalogs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
