amogh-jahagirdar commented on code in PR #411:
URL: https://github.com/apache/iceberg-python/pull/411#discussion_r1485419930
##########
tests/catalog/test_hive.py:
##########
@@ -294,6 +294,37 @@ def test_create_table(table_schema_simple: Schema,
hive_database: HiveDatabase,
assert metadata.model_dump() == expected.model_dump()
+ catalog.create_table(
+ ("default", "table_v1"), schema=table_schema_simple,
properties={"owner": "javaberg", "format-version": "1"}
+ )
+ expected_v1 = TableMetadataV1(
+ location=metadata.location,
+ table_uuid=metadata.table_uuid,
+ last_updated_ms=metadata.last_updated_ms,
+ last_column_id=3,
+ schema=Schema(
Review Comment:
Yeah I was thinking about this, since it's required do we want to have a
validator which sets the Schema based on current-schema-id and schemas? Then
when the V1 metadata gets written out, all 3 fields will be set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
