nk1506 commented on code in PR #9682: URL: https://github.com/apache/iceberg/pull/9682#discussion_r1483877299
########## core/src/main/java/org/apache/iceberg/view/ViewMetadata.java: ########## @@ -68,21 +61,27 @@ default Integer currentSchemaId() { return currentSchemaId; } + @Value.Parameter(order = 1001) + String uuid(); + + @Value.Parameter(order = 1002) + int formatVersion(); + Review Comment: Could you please add more context? i couldn't understand this part. Do you mean something like all the Members of BaseMetadata should be with ViewMetadata too with Override? In that case I dont think we need ` @Value.Parameter(order=?)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org