wolfeidau commented on code in PR #58:
URL: https://github.com/apache/iceberg-go/pull/58#discussion_r1483479148
##########
catalog/catalog.go:
##########
@@ -47,19 +52,136 @@ func WithAwsConfig(cfg aws.Config) Option {
}
}
+func WithCredential(cred string) Option {
Review Comment:
@zeroshade yeah I think it is important to remember that a little
duplication is OK, as long as the user of the API gets a neat typed interface.
Sure internally there maybe some overlap, but that typically erodes over
time as corner cases evolve for each implementation.
As a user of the API I am using Glue + S3, am i likely to switch to hive +
REST?
Personally I prefer a typed interface in Go APIs, over a bag of properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
