zeroshade commented on code in PR #58:
URL: https://github.com/apache/iceberg-go/pull/58#discussion_r1478892511
##########
catalog/catalog.go:
##########
@@ -47,19 +52,136 @@ func WithAwsConfig(cfg aws.Config) Option {
}
}
+func WithCredential(cred string) Option {
Review Comment:
Yea I was thinking the same. Though my question is how many of these options
will overlap with the other catalog implementations. Several of them probably
could overlap. (This is probably why all the options in pyiceberg are all
passed via property mappings)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
