wolfeidau commented on code in PR #58:
URL: https://github.com/apache/iceberg-go/pull/58#discussion_r1474275221
##########
catalog/catalog.go:
##########
@@ -47,19 +52,136 @@ func WithAwsConfig(cfg aws.Config) Option {
}
}
+func WithCredential(cred string) Option {
Review Comment:
It feels like these options are being overloaded with probably only minimal
overlap, do you think we should move these catalog implementations into their
own packages?
I got a feeling this would happen with "common options", interested in your
thoughts.
##########
catalog/glue.go:
##########
@@ -91,7 +92,7 @@ func (c *GlueCatalog) ListTables(ctx context.Context,
namespace table.Identifier
// LoadTable loads a table from the catalog table details.
//
// The identifier should contain the Glue database name, then glue table name.
-func (c *GlueCatalog) LoadTable(ctx context.Context, identifier
table.Identifier, props map[string]string) (*table.Table, error) {
+func (c *GlueCatalog) LoadTable(ctx context.Context, identifier
table.Identifier, props iceberg.Properties) (*table.Table, error) {
database, tableName, err := identifierToGlueTable(identifier)
Review Comment:
we need a better name than `identifierToGlueTable` eh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
