BsoBird commented on code in PR #9546: URL: https://github.com/apache/iceberg/pull/9546#discussion_r1481759800
########## core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java: ########## @@ -289,64 +377,153 @@ Path versionHintFile() { return metadataPath(Util.VERSION_HINT_FILENAME); } - private void writeVersionHint(int versionToWrite) { + @VisibleForTesting + boolean writeVersionHint(FileSystem fs, Integer versionToWrite) throws Exception { Review Comment: I'm just trying to reduce the number of FileSystem objects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org