RussellSpitzer commented on code in PR #9546: URL: https://github.com/apache/iceberg/pull/9546#discussion_r1481739516
########## core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java: ########## @@ -234,7 +313,16 @@ public long newSnapshotId() { } @VisibleForTesting - Path getMetadataFile(int metadataVersion) throws IOException { + boolean isFirstRun() { + return firstRun; + } + + @VisibleForTesting + Path getMetadataFile(Integer metadataVersion) throws IOException { + // TODO:This is not compatible with the scenario where the user modifies the metadata file Review Comment: No Todo's and still not sure this matters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org