BsoBird commented on code in PR #9546:
URL: https://github.com/apache/iceberg/pull/9546#discussion_r1481750312


##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##########
@@ -129,6 +133,36 @@ public TableMetadata refresh() {
 
   @Override
   public void commit(TableMetadata base, TableMetadata metadata) {
+    // findOldVersionHint-------------------->isFirstRun------->JobFail

Review Comment:
   The original intent of this is to 
   1. avoid as much as possible the situation where the versionHint does not 
correspond to the Metadata 
   2. optimise concurrent commits in streaming and LLAP scenarios. If the 
versionHint does not exist, it is assumed that another client is committing, 
and the current client aborts the commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to