mas-chen commented on code in PR #9524:
URL: https://github.com/apache/iceberg/pull/9524#discussion_r1462562799
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/assigner/SplitAssigner.java:
##########
@@ -115,4 +115,7 @@ default void onCompletedSplits(Collection<String>
completedSplitIds) {}
* snapshots and splits, which defeats the purpose of throttling.
*/
int pendingSplitCount();
+
+ /** Pending records count */
Review Comment:
I think of it as more an implementation detail whether it is estimated or
not--perhaps there could be a more accurate way of computing this value in the
future. Rather than leave the comment in the interface, are you ok if we just
leave the comment on the implementing method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
