pvary commented on code in PR #9524:
URL: https://github.com/apache/iceberg/pull/9524#discussion_r1460268581
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/assigner/SplitAssigner.java:
##########
@@ -115,4 +115,7 @@ default void onCompletedSplits(Collection<String>
completedSplitIds) {}
* snapshots and splits, which defeats the purpose of throttling.
*/
int pendingSplitCount();
+
+ /** Pending records count */
Review Comment:
How good is the `split.task().estimatedRowsCount())` which we are using for
the calculations? Shall we state in the comments, or in the method name, that
the value is estimated? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
