mas-chen commented on code in PR #9524:
URL: https://github.com/apache/iceberg/pull/9524#discussion_r1462568032
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java:
##########
@@ -58,9 +61,11 @@
public class TestIcebergSourceContinuous {
+ public static final InMemoryReporter METRIC_REPORTER =
InMemoryReporter.create();
+
@ClassRule
public static final MiniClusterWithClientResource MINI_CLUSTER_RESOURCE =
- MiniClusterResource.createWithClassloaderCheckDisabled();
+ MiniClusterResource.createWithClassloaderCheckDisabled(METRIC_REPORTER);
Review Comment:
That would require refactoring this whole class. I can refactor it but that
is outside the scope of this PR. Otherwise, I can separate out the metric
testing to a new class and use junit5 there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
