nastra commented on code in PR #9382:
URL: https://github.com/apache/iceberg/pull/9382#discussion_r1451547470


##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceReaderDeletes.java:
##########
@@ -44,27 +43,18 @@
 import org.apache.iceberg.relocated.com.google.common.collect.Lists;
 import org.apache.iceberg.relocated.com.google.common.collect.Maps;
 import org.apache.iceberg.util.StructLikeSet;
-import org.junit.ClassRule;
-import org.junit.rules.TemporaryFolder;
 
 public class TestIcebergSourceReaderDeletes extends TestFlinkReaderDeletesBase 
{
 
   private static final int PARALLELISM = 4;
 
-  @ClassRule public static final TemporaryFolder TMP_FOLDER = new 
TemporaryFolder();
-
-  @ClassRule
   public static final MiniClusterWithClientResource MINI_CLUSTER =

Review Comment:
   this should be
   ```
   @RegisterExtension
     public static MiniClusterExtension miniClusterResource =
         MiniFlinkClusterExtension.createWithClassloaderCheckDisabled();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to