nastra commented on code in PR #9382:
URL: https://github.com/apache/iceberg/pull/9382#discussion_r1451545549
##########
mr/src/test/java/org/apache/iceberg/mr/TestInputFormatReaderDeletes.java:
##########
@@ -62,24 +67,20 @@ public static Object[][] parameters() {
};
}
- @Before
+ @BeforeEach
@Override
public void writeTestDataFile() throws IOException {
conf.set(CatalogUtil.ICEBERG_CATALOG_TYPE, Catalogs.LOCATION);
super.writeTestDataFile();
}
- public TestInputFormatReaderDeletes(String inputFormat, FileFormat
fileFormat) {
- this.inputFormat = inputFormat;
- this.fileFormat = fileFormat;
- }
-
@Override
protected Table createTable(String name, Schema schema, PartitionSpec spec)
throws IOException {
Table table;
- File location = temp.newFolder(inputFormat, fileFormat.name());
- Assert.assertTrue(location.delete());
+ File location =
temp.resolve(inputFormat).resolve(fileFormat.name()).toFile();
+ location.mkdirs();
Review Comment:
is this needed? other places in the codebase don't require this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
