chinmay-bhat commented on code in PR #9382:
URL: https://github.com/apache/iceberg/pull/9382#discussion_r1451570358


##########
mr/src/test/java/org/apache/iceberg/mr/TestHelper.java:
##########
@@ -122,7 +144,7 @@ public DataFile writeFile(StructLike partition, 
List<Record> records) throws IOE
   }
 
   private GenericAppenderHelper appender() {
-    return new GenericAppenderHelper(table, fileFormat, tmp, conf);
+    return new GenericAppenderHelper(table, fileFormat, temp, conf);

Review Comment:
   unfortunately this throws errors like `Cannot resolve constructor 
'GenericAppenderHelper(Table, FileFormat, Object, Configuration)`.
   I'll just simplify it into an if statement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to