pvary commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1445940972
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##########
@@ -72,6 +73,23 @@ public static void alterTable(
env.putAll(extraEnv);
env.put(StatsSetupConst.DO_NOT_UPDATE_STATS, StatsSetupConst.TRUE);
- ALTER_TABLE.invoke(client, databaseName, tblName, table, new
EnvironmentContext(env));
+ try {
+ ALTER_TABLE.invoke(client, databaseName, tblName, table, new
EnvironmentContext(env));
+ } catch (RuntimeException e) {
Review Comment:
In the `HiveTableOperations` we are accustomed to handle Hive
`MetaExceptions`, so I think handling `InvalidOperationException` there would
be "natural".
The `alterTable` wraps the exceptions to a `RuntimeException` because of the
`DynMethod` calls. I think this is a mistake. We should behave the same way as
the `metaClients.run(client -> client...)` like calls, we should throw the
original `MetaException` - my opinion here could be changes if this becomes a
breaking change somewhere, but if it does not break code for someone, then we
should change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
